Support SaaS based approval flow for clientIntents
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto evya/approved_intents_crd
…raphQL mutations and queries for applied intents requests
omris94
commented
Feb 26, 2025
| } | ||
|
|
||
| // ApprovedIntentsReconciler reconciles a Intents object | ||
| type ApprovedIntentsReconciler struct { |
There was a problem hiding this comment.
This is essentially what was referred to as the Intents Reconciler
omris94
commented
Feb 26, 2025
| @@ -115,21 +86,39 @@ func NewIntentsReconciler( | |||
| //+kubebuilder:rbac:groups="apiextensions.k8s.io",resources=customresourcedefinitions,verbs=get;list;watch;update;create;patch | |||
| // +kubebuilder:rbac:groups=iam.cnrm.cloud.google.com,resources=iampartialpolicies,verbs=get;list;watch;create;update;patch;delete | |||
|
|
|||
| // Reconcile is part of the main kubernetes reconciliation loop which aims to | |||
| // move the current state of the cluster closer to the desired state. | |||
| // Reconcile - main reconciliation loop | |||
There was a problem hiding this comment.
Explanation about how the "clientIntents to ApprovedClientIntents" lifecycle works
omris94
changed the title
clientIntentsclientIntents
…r upToDates with their corresponding ClientIntents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PLACEHOLDER
References
Include any links supporting this change such as a:
If there are no references, simply delete this section.
Testing
Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).
Checklist