refactor: extract solana-pubkey crate from solana-sdk

[sonicfromnewyoke]

Motivation

as a part of migration mentioned in #3884 solana-pubkey was extracted from solana-sdk and reexported in anchor-client alongside with solana-sdk for now

[vercel]

@sonicfromnewyoke is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

[Otter-0x4ka5h]

I think the crate usage of solana_sdk::pubkey::Pubkey is still being used in some places.

1. https://github.com/sonicfromnewyoke/anchor/blob/5e782ebd793cff81819616bbdbfd6347dc062ad7/cli/src/rust_template.rs#L9
2. https://github.com/sonicfromnewyoke/anchor/blob/5e782ebd793cff81819616bbdbfd6347dc062ad7/cli/src/rust_template.rs#L760-L761

[sonicfromnewyoke]

I think the crate usage of solana_sdk::pubkey::Pubkey is still being used in some places.

1. https://github.com/sonicfromnewyoke/anchor/blob/5e782ebd793cff81819616bbdbfd6347dc062ad7/cli/src/rust_template.rs#L9

2. https://github.com/sonicfromnewyoke/anchor/blob/5e782ebd793cff81819616bbdbfd6347dc062ad7/cli/src/rust_template.rs#L760-L761

my bad, fixed

[jacobcreech]

@sonicfromnewyoke Could you resolve the conflicts?

[swaroop-osec]

@sonicfromnewyoke can you please resolve the merge conflicts?

[sonicfromnewyoke]

@jacobcreech sorry, i missed your message...
@swaroop-osec done

[sonicfromnewyoke]

this CI step fails because CLI generates rust test like follows:

// cli/src/lib.rs
pub const VERSION: &str = env!("CARGO_PKG_VERSION");

// cli/sc/rust_template.rs
pub fn tests_cargo_toml(name: &str) -> String {
    format!(
        r#"[package]
name = "tests"
version = "0.1.0"
description = "Created with Anchor"
edition = "2021"
rust-version = "{msrv}"

[dependencies]
anchor-client = "{version}"
{name} = {{ version = "0.1.0", path = "../programs/{name}" }}
"#,
        msrv = ANCHOR_MSRV,
        version = VERSION,
        name = name,
    )
}

that results into importing anchor-client of the previous version which doesn't contain changes from that commit/MR

to "fix" it we can use relative path to the client instead of the pinned version. What do you think about it @jacobcreech ?

[jacobcreech]

that results into importing anchor-client of the previous version which doesn't contain changes from that commit/MR
to "fix" it we can use relative path to the client instead of the pinned version. What do you think about it @jacobcreech?

This seems fine as it would pass the test after committed. I'll run the tests locally given this PR and see if that's true and then I think we'll be good.

[jamie-osec]

Closing as #4031 will handle this