Remove unused Results in rust client - #3563
Closed
cryptopapi997 wants to merge 4 commits into
Closed
Conversation
|
@cryptopapi997 is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
acheroncrypto
left a comment
acheroncrypto
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but since this is a breaking change, it's best to wait until the next breaking version is ready (most likely v1).
Contributor
Author
|
Quick ping on this if it makes sense to include in 1.0 @jacobcreech |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
@cryptopapi997 Appreciate the ping. We're considering 0.32 before 1.0 so let me get some other reviewers on this |
Aursen
approved these changes
Aug 8, 2025
jacobcreech
moved this from Security Review Required
to Security Review Done
in Anchor 1.0
Collaborator
|
Hey @cryptopapi997 could you combine this one with #3865 to make review easier? |
Contributor
Author
|
Sure, just moved the changes from this branch into #3865, so we can close this one. |
github-project-automation
Bot
moved this from Security Review Done
to Done
in Anchor 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title says it all - a couple functions in the anchor rust client return
Resulteven though they can never return an error, so this PR simplifies that.