Refactor regularized TI costs #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new costs Update tests Final polishing
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
+ Coverage 89.09% 89.39% +0.30%
==========================================
Files 70 71 +1
Lines 7427 7554 +127
Branches 1051 1080 +29
==========================================
+ Hits 6617 6753 +136
+ Misses 659 650 -9
Partials 151 151
|
pkassraie
reviewed
Jun 28, 2024
pkassraie
reviewed
Jun 28, 2024
michalk8
commented
Jul 1, 2024
src/ott/geometry/costs.py
Outdated
| solver = solver.run(x, x=x) | ||
| sol = jax.lax.stop_gradient(solver.params) | ||
| return fun(sol, x) | ||
| x0 = x if x_init is None else x_init |
There was a problem hiding this comment.
I've changed the signature, now it will be possible to do:
cost_fn = ...
f = ...
x_inits = ... # (k, d)
f_h = lambda x: jnp.min(jax.vmap(cost_fn.h_transform(f), in_axes=[None, 0])(x, x_inits)))
michalk8
commented
Jul 1, 2024
pkassraie
reviewed
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.