Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Container::hasParent #4828

Merged
4 commits merged into from
Nov 17, 2024
Merged

Fix Container::hasParent #4828

4 commits merged into from
Nov 17, 2024

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Nov 7, 2024 •
edited
Loading

Pull Request Prelude

Changes Proposed

Fix #4810
Close #4826, #4835

@ghost ghost mentioned this pull request Nov 7, 2024
Closed
3 tasks
ramon-bernardo
ramon-bernardo commented Nov 8, 2024
View reviewed changes
Copy link
Contributor Author

@ramon-bernardo ramon-bernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes

src/game.cpp Show resolved Hide resolved
src/player.cpp Show resolved Hide resolved
@ghost ghost requested a review from ranisalt November 8, 2024 22:45
@ramon-bernardo ramon-bernardo mentioned this pull request Nov 16, 2024
Closed
3 tasks
@ghost ghost merged commit a03f893 into otland:master Nov 17, 2024
19 checks passed
@ramon-bernardo ramon-bernardo deleted the Fix-has-parent-container branch November 17, 2024 00:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranisalt ranisalt ranisalt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramon-bernardo @ranisalt