Skip to content

Improve regexp/strict rule to ignore patterns with v flag #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RunDevelopment merged 2 commits into from
Sep 13, 2023
Merged

Improve regexp/strict rule to ignore patterns with v flag #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e18b8f3
Improve `regexp/strict` rule to ignore patterns with v flag
ota-meshi Sep 10, 2023
17b6485
Create clever-jobs-clap.md
ota-meshi Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-jobs-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-regexp": minor
---

Improve `regexp/strict` rule to ignore patterns with v flag
2 changes: 1 addition & 1 deletion lib/rules/strict.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default createRule("strict", {
const { node, flags, pattern, getRegexpLocation, fixReplaceNode } =
regexpContext

if (flags.unicode) {
if (flags.unicode || flags.unicodeSets) {
// the Unicode flag enables strict parsing mode automatically
return {}
}
Expand Down
3 changes: 2 additions & 1 deletion tests/lib/rules/strict.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import rule from "../../../lib/rules/strict"

const tester = new RuleTester({
parserOptions: {
ecmaVersion: 2020,
ecmaVersion: "latest",
sourceType: "module",
},
})
Expand All @@ -22,6 +22,7 @@ tester.run("strict", rule as any, {
String.raw`/[\( \) \[ \] \{ \} \| \* \+ \? \^ \$ \\ \/ \. \-]/`,
"/\\u000f/",
"/\\x000f/",
String.raw`/[A--B]/v`,
],
invalid: [
// source characters
Expand Down