lib/repo: Refactor object copy import function#923
Closed
cgwalters wants to merge 3 commits intoostreedev:masterfrom
Closed
lib/repo: Refactor object copy import function#923cgwalters wants to merge 3 commits intoostreedev:masterfrom
cgwalters wants to merge 3 commits intoostreedev:masterfrom
Conversation
This came up in: ostreedev#881 Basically doing streaming for metadata is dumb. Split up the metadata/content paths so we pass metadata around as `GVariant`. This drops the last internal caller of `ostree_repo_write_metadata_stream_trusted()` which was the dumb function mentioned.
Member
|
☀️ Test successful - status-atomicjenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in: #881
Basically doing streaming for metadata is dumb. Split up the metadata/content
paths so we pass metadata around as
GVariant. This drops the last internalcaller of
ostree_repo_write_metadata_stream_trusted()which was the dumbfunction mentioned.