checkout: Fix bare-user symlink checkouts#799
Closed
cgwalters wants to merge 1 commit intoostreedev:masterfrom
Closed
checkout: Fix bare-user symlink checkouts#799cgwalters wants to merge 1 commit intoostreedev:masterfrom
cgwalters wants to merge 1 commit intoostreedev:masterfrom
Conversation
Logic error introduced after refactoring; we hoisted the `is_bare_user_symlink` variable to the top, but its computation below. But the `is_bare` symlink depended on it. Closes: ostreedev#798
Member
|
Looks good to me. |
Member
|
Maybe we should have a symlink in our basic tests though? |
Member
Author
|
We did have one, we just weren't verifying it. That's the addition to the test suite I made. Right? |
Member
|
Oh, missed that part. Yeah, that looks good. |
Member
|
Ouch! Just to sanity check, I verified that the new symlink check would have failed without this fix. |
|
☀️ Test successful - status-atomicjenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic error introduced after refactoring; we hoisted the
is_bare_user_symlinkvariable to the top, but its computationbelow. But the
is_baresymlink depended on it.Closes: #798