Skip to content

ci: Run ⊂ of rpm-ostree's vmcheck#771

Closed
cgwalters wants to merge 1 commit intoostreedev:masterfrom
cgwalters:ci-rpmostree
Closed

ci: Run ⊂ of rpm-ostree's vmcheck#771
cgwalters wants to merge 1 commit intoostreedev:masterfrom
cgwalters:ci-rpmostree

Conversation

@cgwalters
Copy link
Copy Markdown
Member

This is a quick hack to get us more than unit testing, albeit indirectly.

See: coreos/rpm-ostree#662

@cgwalters
Copy link
Copy Markdown
Member Author

bot, retest this please

1 similar comment
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 31, 2017

bot, retest this please

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 31, 2017

test comment

1 similar comment
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 31, 2017

test comment

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 31, 2017

bot, retest this please

@rh-atomic-bot
Copy link
Copy Markdown

💥 Invalid .redhat-ci.yml: failed to parse 5th testsuite: host 0 missing key 'distro'.

@cgwalters cgwalters added the WIP label Apr 1, 2017
@cgwalters cgwalters changed the title ci: Run (subset of) rpm-ostree's vmcheck ci: Run ⊂ rpm-ostree's vmcheck Apr 3, 2017
@cgwalters cgwalters changed the title ci: Run ⊂ rpm-ostree's vmcheck ci: Run ⊂ of rpm-ostree's vmcheck Apr 3, 2017
@cgwalters cgwalters force-pushed the ci-rpmostree branch 2 times, most recently from da93041 to 8150abf Compare April 5, 2017 20:35
@cgwalters
Copy link
Copy Markdown
Member Author

So it did break the unit tests, but not vmcheck. Hmm.

@cgwalters cgwalters force-pushed the ci-rpmostree branch 2 times, most recently from 5b4dc10 to f03bf42 Compare January 9, 2018 19:03
@cgwalters
Copy link
Copy Markdown
Member Author

OK, this looks good to go now.

@cgwalters cgwalters removed the WIP label Jan 10, 2018
@cgwalters
Copy link
Copy Markdown
Member Author

(Forgot to mention I'm resurrecting this PR from limbo)

Copy link
Copy Markdown
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

ci/rpmostree.sh Outdated
trap cleanup EXIT
make -j 8 check
# Just a subset ⊂ for now to avoid CI overload
#make vmcheck TESTS=layering-basic
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's at least run test-basic and/or test-layering-basic? Otherwise, there's no point in provisioning a host too, right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the idea was to do the unit tests first. I'll can take a stab at doing those two in this PR, or do you think we should do a separate PR?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it in a separate PR is cool with me! Though maybe let's drop the host provisioning in this PR then?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh let's do it in this one. Working on it now.

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jan 10, 2018

./tests/vmcheck/install.sh: line 32: rsync: command not found

@cgwalters
Copy link
Copy Markdown
Member Author

bot, retest this please

@cgwalters
Copy link
Copy Markdown
Member Author

Hmm, the fact that we failed to log in via ssh is worrying but OTOH the current rpm-ostree PRs are going in and I verified they were using v2017.15-26-g854a823e. Plus local testing passes.

@cgwalters
Copy link
Copy Markdown
Member Author

bot, retest this please

@cgwalters cgwalters force-pushed the ci-rpmostree branch 2 times, most recently from dbb44e7 to 8fbcbbb Compare January 17, 2018 14:40
@cgwalters
Copy link
Copy Markdown
Member Author

(/tmp/tmp.lpaS9ZW5jm/rpm-ostree/.libs/lt-rpm-ostree status:27613): GLib-CRITICAL **: g_source_set_ready_time: assertion 'source->ref_count > 0' failed

Ooh, that one again.

@cgwalters
Copy link
Copy Markdown
Member Author

bot, retest this please

@cgwalters
Copy link
Copy Markdown
Member Author

Jan 17 17:04:12 vmcheck rpm-ostree[1628]: /usr/bin/rpm-ostree: error while loading shared libraries: libsoup-2.4.so.1: cannot open shared object file: No such file or directory

Aaargh, of course.

@cgwalters
Copy link
Copy Markdown
Member Author

f27-rpmostree — All tests passed.

🍾 🥂 🎆

This is a quick hack to get us more than unit testing, albeit indirectly.

See: coreos/rpm-ostree#662
@cgwalters
Copy link
Copy Markdown
Member Author

Rebased 🏄 and squashed 🗜.

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jan 18, 2018

Whoooo, very nice!
@rh-atomic-bot r+ bf90ce3

@rh-atomic-bot
Copy link
Copy Markdown

⌛ Testing commit bf90ce3 with merge 8ea1dc6...

rh-atomic-bot pushed a commit that referenced this pull request Jan 18, 2018
This is a quick hack to get us more than unit testing, albeit indirectly.

See: coreos/rpm-ostree#662

Closes: #771
Approved by: jlebon
@rh-atomic-bot
Copy link
Copy Markdown

💥 Test timed out

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jan 19, 2018

@rh-atomic-bot retry

@rh-atomic-bot
Copy link
Copy Markdown

⌛ Testing commit bf90ce3 with merge 661ec2b...

@rh-atomic-bot
Copy link
Copy Markdown

☀️ Test successful - status-atomicjenkins
Approved by: jlebon
Pushing 661ec2b to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants