Skip to content

Conversation

@jmarrero
Copy link
Member

@jmarrero jmarrero commented Jun 27, 2025

This adds the v2025_3 feature and updates the rust bindings which will expose the soft-reboot capabilities recently introduced.

@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added the area/rust-bindings Relates to the Rust bindings for the C library label Jun 27, 2025
@jmarrero jmarrero changed the title rust: Add v2025_2 feature and bump versions rust: Add v2025_3 feature and bump versions Jun 27, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the versions of the ostree and ostree-sys crates and introduces a new feature flag, v2025_3. My review has identified a couple of issues. Firstly, the new feature is missing its corresponding metadata for system-deps, which could lead to incorrect system library version checks. Secondly, the pull request title is inconsistent with the changes, as it mentions v2025_2 instead of the newly added v2025_3. I've provided comments with suggestions to address these points.

@cgwalters
Copy link
Member

LGTM as is but marking draft since this needs to wait for a release of the C library.

@jmarrero jmarrero marked this pull request as ready for review July 10, 2025 16:43
@jmarrero
Copy link
Member Author

@cgwalters can you merge and do the bindings crate release?

@cgwalters cgwalters merged commit d47a59c into ostreedev:main Jul 10, 2025
23 of 25 checks passed
@jmarrero jmarrero mentioned this pull request Jul 10, 2025
33 tasks
@cgwalters
Copy link
Member

Published https://crates.io/crates/ostree/0.20.3 !

@cgwalters
Copy link
Member

Hmm I'm trying to regenerate things locally and getting

target/tools/bin/gir -c conf/ostree-sys.toml
Error: "GirXml: conf/../gir-files/OSTree-1.0.gir at line 13:3: Unexpected element <format>"

Did you not hit this?

@cgwalters
Copy link
Member

I punted and just updated the GIR_VERSION in #3475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/rust-bindings Relates to the Rust bindings for the C library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants