-
Notifications
You must be signed in to change notification settings - Fork 336
rust: Add v2025_3 feature and bump versions #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the versions of the ostree and ostree-sys crates and introduces a new feature flag, v2025_3. My review has identified a couple of issues. Firstly, the new feature is missing its corresponding metadata for system-deps, which could lead to incorrect system library version checks. Secondly, the pull request title is inconsistent with the changes, as it mentions v2025_2 instead of the newly added v2025_3. I've provided comments with suggestions to address these points.
|
LGTM as is but marking draft since this needs to wait for a release of the C library. |
|
@cgwalters can you merge and do the bindings crate release? |
|
Published https://crates.io/crates/ostree/0.20.3 ! |
|
Hmm I'm trying to regenerate things locally and getting Did you not hit this? |
|
I punted and just updated the GIR_VERSION in #3475 |
This adds the v2025_3 feature and updates the rust bindings which will expose the soft-reboot capabilities recently introduced.