tests: Check that example symbol isn't released#2135
Merged
openshift-merge-robot merged 1 commit intoostreedev:masterfrom Jun 18, 2020
Merged
tests: Check that example symbol isn't released#2135openshift-merge-robot merged 1 commit intoostreedev:masterfrom
openshift-merge-robot merged 1 commit intoostreedev:masterfrom
Conversation
mwleeds
force-pushed
the
test-symbols-check-for-example
branch
2 times, most recently
from
cec1f29 to
98d5353
Compare
For the motivation for this see ostreedev#2132.
mwleeds
force-pushed
the
test-symbols-check-for-example
branch
from
98d5353 to
d211816
Compare
Member
Author
|
Had to fix some silly mistakes. Sorry, I'll test locally next time. I did check locally that the new library function |
Member
|
Thank you! |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, mwleeds The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the motivation for this see #2132.