Skip to content

Conversation

@cgwalters
Copy link
Member

This builds on
coreos/coreos-assembler#1441
to install our tests rather than running them from the source
directory. This model will more cleanly allow us to ship
our tests along with a test container or elsewhere, separate
from the source directory.

Also prep for #2048

@cgwalters cgwalters force-pushed the make-install-kola-tests branch 2 times, most recently from e7ce4fe to 34908f1 Compare May 15, 2020 17:16
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but LGTM as is!

@cgwalters
Copy link
Member Author

To expand on this, there's a few directions we could go with this.

One I am leaning towards a bit is where we have a quay.io/coreos/tests container that does:

FROM quay.io/coreos-assembler:latest
RUN git clone https://github.com/ostreedev/ostree && cd ostree && make -C tests/kola install
RUN git clone https://github.com/coreos/ignition && cd ignition && make -C tests/kola install

etc.

There's already an ostree-tests RPM...but using it would be a bit awkward anyways because for cosa we need to support src != target. Plus I'd like to support updating the tests without updating the content.

@dustymabe
Copy link
Contributor

I don't think I have an opinion here. Thanks for continuing to keep testing at a high priority.

This builds on
coreos/coreos-assembler#1441
to install our tests rather than running them from the source
directory.  This model will more cleanly allow us to ship
our tests along with a test container or elsewhere, separate
from the source directory.

Also prep for ostreedev#2048
@cgwalters cgwalters force-pushed the make-install-kola-tests branch from 34908f1 to 48f5a18 Compare May 15, 2020 19:41
@jlebon
Copy link
Member

jlebon commented May 15, 2020

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b5e51d8 into ostreedev:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants