Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement support for else clauses in for loops. fixes osteele/liquid#46 #93

Merged
merged 1 commit into from
Oct 17, 2024
Merged

implement support for else clauses in for loops. fixes osteele/liquid#46 #93

merged 1 commit into from
Oct 17, 2024

Conversation

codykrieger
Copy link
Contributor

What it says on the tin!

I added a handful of basic tests, but I'm happy to add more if there are any cases I've missed.

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

@codykrieger codykrieger mentioned this pull request Oct 5, 2024
Closed
@danog
Copy link
Collaborator

danog commented Oct 17, 2024

Thanks!

@danog danog merged commit b975919 into osteele:main Oct 17, 2024
@codykrieger codykrieger deleted the cjk/for-else branch October 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codykrieger @danog