Fix slice #72
Open
Fix slice #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests currently pass, so I'm committing them alone I intend on changing the implementation and need to ensure they stay green.
The previous implementation compiled a regex on the fly, using a repetition count that could go above the supported range, causing it to panic. This implementation should work on any string size, offset and length. I added edge case tests when using out-of-bounds values. I do not know what Shopify implementation would return, and the documentation does not specify any behavior, so I came up with a sensible behavior.
Shopify's Liquid documentation says it works on arrays. This was not covered by the previous implementations.
|
Hi! Mind rebasing this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slicewas broken with an offset or length above 1000.Shopify documents that
slicesupports arrays in addition to strings; I added support for working on slices.Checklist
make testpasses.make lintpasses. (at least on modified files)