Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loop modifiers to be more than just literals #67

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

aisbergg
Copy link
Contributor

@aisbergg aisbergg commented Apr 22, 2022

This PR adds the ability to specify variables and expressions in loop modifiers. Example:

{% assign limit = 3 %}
{% assign offset = 1 %}
{% for i in (1..5) limit:limit offset:offset %}
{{ i -}}
{%- endfor %}

results in:

2
3
4

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

@aisbergg aisbergg changed the title Allow loop modifiers to be either literal or a variable Allow loop modifiers to be more than just literals Apr 24, 2022
@danog danog merged commit 66a8e52 into osteele:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants