Accessibility improvements on club listing page and leaders corner page #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove underline from heading-level links
alexdor
requested changes
Oct 10, 2019
| className="club-teaser__image" | ||
| /> | ||
| </div> | ||
| <div className="club-teaser__text"> | ||
| <h2 className="club-teaser__title">{title}</h2> | ||
| <h2 className="club-teaser__title" id={title.replace(/\s/g, "")}> |
There was a problem hiding this comment.
Suggested change
| <h2 className="club-teaser__title" id={title.replace(/\s/g, "")}> | |
| <h2 className="club-teaser__title" id={(title||"").replace(/\s/g, "")}> |
Could you safeguard the replace call here?
| @@ -13,9 +13,16 @@ export default props => { | |||
| <div className={classes}> | |||
| <ShadowBox> | |||
| <div className="faq__group-header"> | |||
| <h2 title="title title--x-small">{props.header}</h2> | |||
| <h2 title="title title--x-small" id={props.header.replace(/\s/g, "")}> | |||
There was a problem hiding this comment.
Could you safeguard the replace call here from null header?
| <ul className="faq__group-content">{props.children}</ul> | ||
| <ul | ||
| className="faq__group-content" | ||
| aria-labelledby={props.header.replace(/\s/g, "")} |
There was a problem hiding this comment.
Could you safeguard the replace call here from null header?
Merge branch 'master' of github.com:ossn/ossn-frontend into accessibility
alexdor
requested changes
Oct 13, 2019
| @@ -15,7 +15,7 @@ | |||
| a, | |||
| %link { | |||
| color: color(link); | |||
| text-decoration: none; | |||
| // text-decoration: none; | |||
There was a problem hiding this comment.
Could you delete this instead of commenting it out?
alexdor
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #263 since it's an accessibility fix.
Commit a409f9a:
Commit a9c7d5b:
Commit b6bda7d: