Open code in external editor

[samamou]

• Reuse previous editor instance instead of launching a new one each time and ending up with 30 sublime / vscode files open for each edit :')
  • before creating a new file, check if it exists?

[jcelerier]

[samamou]

QFileSystemWatcher to monitor if a temp file changes externally + syncs updates back into the score editor? @jcelerier

[jcelerier]

yep ! but keep in mind this issue: https://stackoverflow.com/questions/18300376/qt-qfilesystemwatcher-signal-filechanged-gets-emited-only-once/18304496

so a bit of intelligence is needed - I think the best way is the answer that proposes watching the parent folder for newly created file, and check if it matches.

Also I think this behaviour should be encapsulated in a entirely separate utility class as there is this requirement in multiple other places in ossia :)

[samamou]

oki another crash on thread 20 here score-crash.txt
trying to retrace what i did that caused this

[jcelerier]

great, I have small nitpicks but the code looks very clean, !

[samamou]

I spoke to Lou and Zach briefly about scripting in other software to discuss the behavior they expect

Feedback:

• Workflow / sync : they expect the external editor changes to update in score automatically onSave(), aligning with live-coding workflows

• Error feedback : they both expect visual feedback indicating an issue (syntax error) directly on or near the node in the scenario editor. Feedback from bespoke editor:

Possible quick implementation:

It also got me thinking, is it possible to have this open up and direct the log/output here / to another terminal instead of the QTextEditor + give feedback onCompile()/onRun() such as adding a comment block SUCCESSFULLY COMPILED

• Code MiniView (Internal viewer) : they appreciate having a quick inline read-only view of the code without needing to open a full external editor. They said "Currently in score, a Dialog blocks your view of the Scenario Editor" blocks feels like a heavy word, and i guess there could be a lighter way of presenting this information, for quick checking. For example, a collapsible inline "peek" panel? (not sure how this would like)

https://nodes.io/

vscode peek window

@jcelerier can you please tell me which is high/ low effort?

[jcelerier]

Amazing thanks for this analysis !

[jcelerier]

Workflow / sync : they expect the external editor changes to update in score automatically onSave(), aligning with live-coding workflows

sounds like what we discussed earlier, this is also what i'd expect as behaviour

Error feedback : they both expect visual feedback indicating an issue (syntax error) directly on or near the node in the scenario editor.

yep, that sounds doable (in a further PR!). Should be done here: https://github.com/jcelerier/QCodeEditor ; I also like the "red" error state that you propose, imho this one should be generalised as there are definitely non-code-editor things which can be in erroneous states like this!

For the immediate needs though, I think a bespoke-like thing with the line being underlined is the best bet. (again, in a further PR, this is another feature on top of this one.)

Code MiniView (Internal viewer) : they appreciate having a quick inline read-only view of the code without needing to open a full external editor. They said "Currently in score, a Dialog blocks your view of the Scenario Editor" blocks feels like a heavy word, and i guess there could be a lighter way of presenting this information, for quick checking. For example, a collapsible inline "peek" panel? (not sure how this would like)

yeah, this one's more of a challenge and to be thought of as part of a more general "debug overlays" feature, e.g. to see for instance not only code but also inputs & outputs signals, textures, etc.