Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Include QUrl #1619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Include QUrl #1619

wants to merge 1 commit into from

Conversation

aalex
Copy link
Collaborator

@aalex aalex commented Dec 11, 2024

Fixes a build error on Pop OS 22.04.

@aalex aalex self-assigned this Dec 11, 2024
@aalex
Copy link
Collaborator Author

aalex commented Dec 19, 2024

I think there was another branch with the fix: #1613
And these changes might have been integrated into the main branch in another PR, anyways.

@jcelerier
Copy link
Member

Hm I don't see it in master, let's put it there and rebase wip/pico-next on master afterwards

@jcelerier jcelerier changed the base branch from wip/pico-next to master December 20, 2024 17:57
@jcelerier
Copy link
Member

Argh, though this brings all the wip/pico-next commits with that... could you instead change this branch so that it is this commit

e58e54e

cherry-picked on top of current master ?

(or just with the branch force-pushed as I think it would be equally fast to just redo the commit than to type git cherry-pick...)

@aalex
Copy link
Collaborator Author

aalex commented Dec 21, 2024

It should be better, now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Under review
Development

Successfully merging this pull request may close these issues.

2 participants