Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields for OpenSSF Best Practices Badge, fixes #93 #94

Closed

Conversation

david-a-wheeler
Copy link
Contributor

No description provided.

@david-a-wheeler
Copy link
Contributor Author

Here's my attempt to add support for all (important) OpenSSF Best Practices Badge data to SECURITY-INSIGHTS. Comments welcome. @eddie-knight @SecurityCRob

@david-a-wheeler
Copy link
Contributor Author

Note: It might be better if some or all of the "special keys" went to "headers" instead. If so, we'd need to figure out what the current URL is (repo_url or project_url?). The list aof implementation languages should perhaps be an array of strings instead. The current criteria keys could be explicitly listed (for simplicity I didn't do that)... that would be easy to generate with a script.

@david-a-wheeler
Copy link
Contributor Author

Also, maybe "license" should be named "license_expression" to make it more obvious what it is.

@david-a-wheeler david-a-wheeler marked this pull request as draft September 25, 2024 14:44
@david-a-wheeler
Copy link
Contributor Author

I'm labeling this as draft, I think many keys need to move to headings. I'd love to hear thoughts

Signed-off-by: David A. Wheeler <[email protected]>
This also checks in a small script that can automatically
regenerate this section. The script makes it easier to make
mass changes/updates.

Signed-off-by: David A. Wheeler <[email protected]>
@david-a-wheeler david-a-wheeler marked this pull request as ready for review September 26, 2024 03:00
@david-a-wheeler
Copy link
Contributor Author

I think it's ready now, but this needs review. Comments welcome.

@eddie-knight
Copy link
Contributor

We'll need to continue this discussion in light of the recent changes in the v2 release. The PR linked above might be a good starting point. I'll also make note of this on #93.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants