📖 explicitly state both check documentation files are committed #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
a team,
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
1 task
|
Friendly ping @raghavkaul @justaugustus |
raghavkaul
approved these changes
Sep 19, 2024
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
Sep 29, 2024
…#4317) Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: balteraivshay <[email protected]>
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
Oct 3, 2024
…#4317) Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: balteraivshay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
doc update
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Clarify that both check files should be committed in order to pass the
generate-docsCI job.scorecard/.github/workflows/main.yml
Lines 166 to 167 in a99119b
Which issue(s) this PR fixes
See #4316 (review)
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)