-
Notifications
You must be signed in to change notification settings - Fork 530
🌱 attestor: e2e tests #2529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 attestor: e2e tests #2529
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
==========================================
- Coverage 40.73% 40.69% -0.05%
==========================================
Files 115 115
Lines 9613 9609 -4
==========================================
- Hits 3916 3910 -6
- Misses 5418 5419 +1
- Partials 279 280 +1 |
Integration tests success for |
Signed-off-by: Raghav Kaul <[email protected]>
instead of all Signed-off-by: Raghav Kaul <[email protected]>
894f4e1
to
f0228ef
Compare
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc change LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add E2E tests Signed-off-by: Raghav Kaul <[email protected]> * Change RequiredApprovers so that it checks for any reviewers on the list instead of all Signed-off-by: Raghav Kaul <[email protected]> Signed-off-by: Raghav Kaul <[email protected]> Co-authored-by: Azeem Shaikh <[email protected]>
What kind of change does this PR introduce?
Add E2E tests. Also refactor the check runner to allow dependency injection.