-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 cron: generalize and expose worker (6/n) #2317
🌱 cron: generalize and expose worker (6/n) #2317
Conversation
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Not sure if Friday is the best time to merge something like this, but wanted to get it up for discussion for any changes. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
=======================================
Coverage 40.61% 40.61%
=======================================
Files 112 112
Lines 8831 8831
=======================================
Hits 3587 3587
Misses 4984 4984
Partials 260 260 |
Integration tests success for |
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
876acb0 will cause metadata to be populated to the BigQuery results. Might be worth spinning this off in it's own PR |
Integration tests success for |
Stale pull request message |
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Integration tests success for |
Oh, so this was the bug all along. Yeah doing this in a separate PR SGTM. |
This reverts commit 876acb0. Will send separate PR. Signed-off-by: Spencer Schrock <[email protected]>
Integration tests success for |
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Head branch was pushed to by a user without write access
Integration tests success for |
* WIP Signed-off-by: Spencer Schrock <[email protected]> * Appease linter. Signed-off-by: Spencer Schrock <[email protected]> * Update Makefile for worker Signed-off-by: Spencer Schrock <[email protected]> * Extract already completed request sanity check. Signed-off-by: Spencer Schrock <[email protected]> * Add worker test. Signed-off-by: Spencer Schrock <[email protected]> * remove logger from worker interface Signed-off-by: Spencer Schrock <[email protected]> * move cron data and worker out of cron/internal Signed-off-by: Spencer Schrock <[email protected]> * Move config out of internal. Signed-off-by: Spencer Schrock <[email protected]> * Document worker interface. Signed-off-by: Spencer Schrock <[email protected]> * Fix typo which prevented metadata from going to cron job. Signed-off-by: Spencer Schrock <[email protected]> * Address feedback. Signed-off-by: Spencer Schrock <[email protected]> * Revert "Fix typo which prevented metadata from going to cron job." This reverts commit 876acb0. Will send separate PR. Signed-off-by: Spencer Schrock <[email protected]> * Fix linter. Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: latortuga <latortugaaaa>
* WIP Signed-off-by: Spencer Schrock <[email protected]> * Appease linter. Signed-off-by: Spencer Schrock <[email protected]> * Update Makefile for worker Signed-off-by: Spencer Schrock <[email protected]> * Extract already completed request sanity check. Signed-off-by: Spencer Schrock <[email protected]> * Add worker test. Signed-off-by: Spencer Schrock <[email protected]> * remove logger from worker interface Signed-off-by: Spencer Schrock <[email protected]> * move cron data and worker out of cron/internal Signed-off-by: Spencer Schrock <[email protected]> * Move config out of internal. Signed-off-by: Spencer Schrock <[email protected]> * Document worker interface. Signed-off-by: Spencer Schrock <[email protected]> * Fix typo which prevented metadata from going to cron job. Signed-off-by: Spencer Schrock <[email protected]> * Address feedback. Signed-off-by: Spencer Schrock <[email protected]> * Revert "Fix typo which prevented metadata from going to cron job." This reverts commit 876acb0. Will send separate PR. Signed-off-by: Spencer Schrock <[email protected]> * Fix linter. Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: nathaniel.wert <[email protected]>
* WIP Signed-off-by: Spencer Schrock <[email protected]> * Appease linter. Signed-off-by: Spencer Schrock <[email protected]> * Update Makefile for worker Signed-off-by: Spencer Schrock <[email protected]> * Extract already completed request sanity check. Signed-off-by: Spencer Schrock <[email protected]> * Add worker test. Signed-off-by: Spencer Schrock <[email protected]> * remove logger from worker interface Signed-off-by: Spencer Schrock <[email protected]> * move cron data and worker out of cron/internal Signed-off-by: Spencer Schrock <[email protected]> * Move config out of internal. Signed-off-by: Spencer Schrock <[email protected]> * Document worker interface. Signed-off-by: Spencer Schrock <[email protected]> * Fix typo which prevented metadata from going to cron job. Signed-off-by: Spencer Schrock <[email protected]> * Address feedback. Signed-off-by: Spencer Schrock <[email protected]> * Revert "Fix typo which prevented metadata from going to cron job." This reverts commit 876acb0. Will send separate PR. Signed-off-by: Spencer Schrock <[email protected]> * Fix linter. Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: nathaniel.wert <[email protected]>
* WIP Signed-off-by: Spencer Schrock <[email protected]> * Appease linter. Signed-off-by: Spencer Schrock <[email protected]> * Update Makefile for worker Signed-off-by: Spencer Schrock <[email protected]> * Extract already completed request sanity check. Signed-off-by: Spencer Schrock <[email protected]> * Add worker test. Signed-off-by: Spencer Schrock <[email protected]> * remove logger from worker interface Signed-off-by: Spencer Schrock <[email protected]> * move cron data and worker out of cron/internal Signed-off-by: Spencer Schrock <[email protected]> * Move config out of internal. Signed-off-by: Spencer Schrock <[email protected]> * Document worker interface. Signed-off-by: Spencer Schrock <[email protected]> * Fix typo which prevented metadata from going to cron job. Signed-off-by: Spencer Schrock <[email protected]> * Address feedback. Signed-off-by: Spencer Schrock <[email protected]> * Revert "Fix typo which prevented metadata from going to cron job." This reverts commit 876acb0. Will send separate PR. Signed-off-by: Spencer Schrock <[email protected]> * Fix linter. Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Spencer Schrock <[email protected]>
What kind of change does this PR introduce?
Part of a series of refactors to generalize the cron infrastructure to enable re-use by the ossf criticality score project
What is the current behavior?
The worker logic is scorecard specific and can't be re-used.
What is the new behavior (if this is a feature change)?**
The general logic has been separated from the scorecard specific logic.
Criticality should be able to import the required modules and create their own worker which implements the interface.
The following packages are (re) exposed in
cron
:config
data
worker
more of a refactor of existing code. the worker release test should catch any major errors.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)