Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Unflag the --commit option #2156

Merged
merged 2 commits into from
Aug 16, 2022
Merged

✨ Unflag the --commit option #2156

merged 2 commits into from
Aug 16, 2022

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Allow users of Scorecard CLI to use the --commit option without needing to set SCORECARD_V6=1.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Adds a new flag `--commit` to allow per-commit analysis

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test August 16, 2022 22:10 Inactive
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #2156 (055f096) into main (ff9c062) will increase coverage by 2.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2156      +/-   ##
==========================================
+ Coverage   42.47%   44.80%   +2.33%     
==========================================
  Files          94       94              
  Lines        7838     7825      -13     
==========================================
+ Hits         3329     3506     +177     
+ Misses       4251     4054     -197     
- Partials      258      265       +7     

@github-actions
Copy link

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) August 16, 2022 23:11
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test August 16, 2022 23:15 Inactive
@github-actions
Copy link

@azeemshaikh38 azeemshaikh38 merged commit 6001571 into main Aug 16, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/commit branch August 16, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants