Remove annoying win32ui dialog box

[awiddersheim]

If you close the win32ui, the win32ui is running with Administrative
privileges, everything to run the win32 agent is configured and the
Agent service is not running a dialog box will pop informing the user
the service is not running and ask them if they would like to start it.

This to me is an annoyance more than anything. It is likely the user
went into the win32ui to stop the service to begin with and knows it is
stopped.

If anyone has any strong opinions on keep this I'm all ears.

[mstarks01]

One instance when this appears when the service is not running is right after installation (the final step has launch UI by default). In this instance, I think it's appropriate to prompt the user to start the service.

[awiddersheim]

Again, this only happens after you close the UI not before and only when everything that is needed for the agent to start is configured and the service isn't running. So it may or may not show up depending on what the user does after it is first launched.

It doesn't really show up often but when it does I think it is stupid.

[mstarks01]

So if the UI is launched after install and the user configures the key and then closes it, OSSEC will prompt them to start the service, right? That is the current behavior. I believe that is helpful and correct. I would also want to know if I was closing the UI and the service isn't running. I would rather be notified and take action to start the service than not get logs and alerts.

[awiddersheim]

Your understanding of the logic and how it works is correct. Though we seem to disagree on the usefulness of the dialog box which is fine.

Perhaps I should make a post on the mailing list to try and get more opinions.

[jrossi]

The code is correct and make sense and is less magic happens this way. I think we are gonna need to release 2.8 anyway due to all the changes so lets add this.

I would love to see an 🔴 and other status of the service is GUI.

[mstarks01]

This will cause people to potentially miss alerts about an attack when it could have been avoided by keeping the dialogue box. If it annoys you then make it a configurable option. But it has been merged so that's all I have to say.