Feature/nfs exclusion v2 #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/rootcheck/check_rc_sys.c
NFS mounts are scanned. The defaults do scan NFS mounts, which is consistent with existing functionality. Conflicts: src/config/rootcheck-config.c src/rootcheck/check_rc_sys.c
Conflicts: src/config/syscheck-config.c src/syscheckd/config.c src/syscheckd/create_db.c
the define back and removed trailing whitespace. Conflicts: src/Makefile
using a struct[] to handle the flags we want to skip if <skip_nfs>yes</skip_nfs> which makes adding new entries easier. Idea stolen from @jrossi and brutally mutalated by me.
debugging messages to ensure code paths are being followed.
|
@reyjar could you add some documentation for this? With docs I feel people will get lost with this feature. |
|
Added documentation on : ossec/ossec-docs#94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the <skip_nfs>yes</skip_nfs> option in rootcheck and syscheck. Since it's available, it also warns if a user attempts to iNotify on an NFS partition as that is not supported by iNotify.