-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible fix to vista_sec.csv #526
Conversation
Delete the ones you put on their own lines? |
This reads in the file creating a hash: Then this searches the hash using the event ID and formats the message: EDIT: oops had wrong line number in second part. |
Anyway... this seems reasonable to me. I guess I'm still confused on your doubts about it. |
This will work for OSSEC but is still not real CSV and github will still complain about it. |
Ah, because of the extra comma separators? Maybe we should rename the file so github won't think it's CSV anymore and properly handle indexing it and what not. |
Or maybe use a different separator? |
I don't think it's useful to change the separator or the logic so it could read proper CSV so one file can be indexed by github. As it stands now there was a bug in this file (improper description lines) that is now gone. |
Yeah, but the work to change isn't outrageous which is why I proposed it. Also, I use git's search a lot and ran up against and issue where I was trying to find stuff in this file and wasn't able to because git wasn't indexing I guess. |
Fix line breaks in vista_sec.csv
try to fix #525 I couldn't find the correct descriptions of those event ids. Maybe it's better to just delete them? I don't know how this is used inside OSSEC.