Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit on single unit test failure #512

Merged
merged 1 commit into from
Feb 1, 2015
Merged

exit on single unit test failure #512

merged 1 commit into from
Feb 1, 2015

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Jan 29, 2015

No description provided.

@wclarie
Copy link
Contributor

wclarie commented Jan 29, 2015

Does that mean that if there are multiple checks, this will fail on the first one? Isn't is useful to find out all the failing tests instead of just the first one?

@cgzones
Copy link
Contributor Author

cgzones commented Jan 29, 2015

Good point. There are several binaries with several checks. Now all binaries are executed but if any fails the failure is not propagated to the makefile (so travis will succeed).
With this change make will abort after the first failed binary, but in this binary all checks are executed.

@jrossi jrossi added this to the ossec-hids-2.9 milestone Feb 1, 2015
@jrossi
Copy link
Member

jrossi commented Feb 1, 2015

Seeing all the failures is useful, but passing tests becuase it was not the last one is a bug. I am going to accept this and make sure things don't slip by we can make it better anytime.

Plus this is how most of makefile currently works. If it exits with anything other then 0 everything stops ;)

jrossi added a commit that referenced this pull request Feb 1, 2015
exit on single unit test failure
@jrossi jrossi merged commit ed069cc into ossec:master Feb 1, 2015
@cgzones cgzones deleted the test_failure branch February 2, 2015 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants