Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FQDN in csyslogd #501

Merged
merged 2 commits into from
Jan 21, 2015
Merged

Add support for FQDN in csyslogd #501

merged 2 commits into from
Jan 21, 2015

Conversation

ccooke
Copy link

@ccooke ccooke commented Jan 21, 2015

Hi,

The existing csyslogd always truncates hostnames in the syslog output at the first '.', which creates a lot of ambiguity if you differentiate hosts by a hierarchical DNS scheme. These patches add a "use_fqdn" option into the syslog config that toggles between using the short or full hostname.

Some notes:

  • The default behaviour is to use the short hostname, so current behaviour is preserved
  • I would have preferred to make this a global option (since hostnames are truncated in a few places) but it looks like csyslogd only has infrastructure to read its own configuration at the moment. Adding the global option would be a much more invasive change
  • The code works on a per syslog config block basis, which looks to be the expected method.

Thanks,

ddpbsd added a commit that referenced this pull request Jan 21, 2015
Add support for FQDN in csyslogd
@ddpbsd ddpbsd merged commit a6cd5ba into ossec:master Jan 21, 2015
@ddpbsd
Copy link
Member

ddpbsd commented Jan 21, 2015

I'd love to see a pull request for ossec-docs as well. (or at least an issue so I remember to update later)

@ddpbsd
Copy link
Member

ddpbsd commented Jan 21, 2015

docs/syntax/ossec_config.syslog_output.trst please

On Wed, Jan 21, 2015 at 1:06 PM, C. Cooke [email protected] wrote:

No problem. I have that written here - just checking, should I add to
docs/syntax/head_ossec_config.syslog_output.rst or
docs/syntax/ossec_config.syslog_output.trst

Presuming the head version?

Reply to this email directly or view it on GitHub
#501 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants