Fix build settings

[awiddersheim]

No description provided.

[jrossi]

Going recessive on makefiles is general what we are trying to get away from.

if you need to do this you need to the build: ${TARGET} to build: settings using ifndef.

[awiddersheim]

I'm not really sure what you mean. Sorry. Can you try explaining differently or using a code example of how this should be done?

[jrossi]

Should be done like this:

ifneq (${TARGET},failtarget)
build: ${TARGET}
else 
build: failtarget 
endif 

[awiddersheim]

I'm not sure how that is going to fix the problem I am trying to solve. Perhaps I should explain the issue more. Right now if I just do make with no TARGET specified, the help is displayed as well as the settings. I don't really find that necessary. This commit prevents the settings from being displayed in that occurrence.

[jrossi]

i will just shut my cake hole now ;)

Yeah i did not get it on a few levels.

[awiddersheim]

Haha. OK. No problem. Hopefully, things are more clear now? I'm open to making things better and taking feedback. It is no problem.

[jrossi]

Personal input and nothing more:

The make files are not for users they are for developers. I use it to verify the config and settings are what I expect when doing different things. Also makes sense for travis-ci where output is recorded for review later.

Default for users should always be less OUTPUT unless something bad happens. And another point WE ARE not users what were like are different then what users like :) i think ;)

[awiddersheim]

This makes sense. I never read this before or I just merely glanced over your thinking from the other pull request. I think in general that logic is fine.

If you are in opposition of removing the settings output than I'm not opposed. I made the pull request merely as a suggestion but no hard feelings if it is removed.

#346

Perhaps I am still misunderstanding something.

[jrossi]

no feelings ;) i just complete miss read what you were doing on this pull request. This is 100% my fault ;)

[awiddersheim]

OK. No worries.

[jrossi]

I should make it clear I don't care enough to be in opposition of anything that goes on with settings. I mean if people like it will stay. They don't it will go, but never by my hand :)

I might push to make the build visually clean to users so that when it outputs errors it feels like a bug. Less griberish on the screen for users makes the software seam more complete and finished. Redis is my example of this. People open up bug reports for warning messages and I think that is great.

[awiddersheim]

Thanks for clarifying. Lets get this merged?

[cgzones]

Maybe you can extend the condition until the end of build, cause the green output Done building failtarget is a little bit irritating?

[awiddersheim]

@cgzones I update the pull request with the suggested changes.