Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display defaults for PREFIX and MAXAGENTS in make help #351

Merged
merged 1 commit into from
Oct 7, 2014
Merged

display defaults for PREFIX and MAXAGENTS in make help #351

merged 1 commit into from
Oct 7, 2014

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Oct 7, 2014

No description provided.

jrossi added a commit that referenced this pull request Oct 7, 2014
display defaults for PREFIX and MAXAGENTS in make help
@jrossi jrossi merged commit 469218d into ossec:master Oct 7, 2014
@awiddersheim
Copy link
Member

I am wondering if it would be better to use the variables ($PREFIX and MAXAGENTS) when displaying the defaults.

Someone could do something like make PREFIX=blah help and see the wrong data. Perhaps setting a DEFAULT_PREFIX variable that gets set to the PREFIX variable. Start to complicate the code then. Just thinking out loud.

@cgzones cgzones deleted the defaults branch October 7, 2014 21:46
@cgzones
Copy link
Contributor Author

cgzones commented Oct 8, 2014

I'm not convinced: in my opinion make help should display the defaults for typing type make TARGET=xy build. To see what effects PREFIX=blah has, the target settings can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants