Skip to content

Fix include order warnings when compiling win32 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2014

Conversation

awiddersheim
Copy link
Member

When compiling win32 it warns about including windows.h before
winsock2.h. Since Windows cannot use inotify remove the local includes
for the Windows components and let the later inclusion of shared.h
handle the inclusion of all the necessary Windows libraries.

Fixes:

In file included from headers/shared.h:83:0,
                 from run_realtime.c:45:
/usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/winsock2.h:15:2: warning: #warning Please include winsock2.h before windows.h [-Wcpp]

When compiling win32 it warns about including windows.h before
winsock2.h. Since Windows cannot use inotify remove the local includes
for the Windows components and let the later inclusion of shared.h
handle the inclusion of all the necessary Windows libraries.
@jrossi jrossi added this to the ossec-hids-2.9 milestone Oct 6, 2014
jrossi added a commit that referenced this pull request Oct 6, 2014
Fix include order warnings when compiling win32
@jrossi jrossi merged commit 7999a26 into ossec:master Oct 6, 2014
@awiddersheim awiddersheim deleted the fix_win32_include_warnings branch October 9, 2014 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants