-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql changes - all the mysql related patches from the atomic spec #249
mysql changes - all the mysql related patches from the atomic spec #249
Conversation
@ossec as the submitter I can it accept. @atomicturtle uses this in the rpm and we need to get the rpm and src installs to be the same code. |
I don't use mysql, or I would test this. If I get some free time I'll try to setup an instance. |
merging this unto master - should pass travis now. |
I would like to get this pulled in before 2.9 so that we can make sure that the code in RPM's match the source release. We should not be calling atomic rpm the same till this happens. <-- going forward ;) i just want to make sure that we release the same code for everything. Please review @ossec |
ossec-hids-mysql-schema-fix1.patch consolidate-alert-mysql-2 os_dbd-mysql-replace-query.patch mysql-schema-if-exists.patch mysql-schema-is_hidden.patch mysql-disable-max-id.patch mysql-schema-tld.patch disable-signature-sql.patch |
@ossec i can not accept this as i created the Pull Request. Someone else will need to review and accept. I am not worried much as atomic is shipping this now to customers, but we should review it anyway. |
I don't know enough about the database stuff to review confidently. |
Is @atomicturtle not able to do review and merge this? He seems like the most logical person. |
We are in a weird place - he is also the author. I will move then in soon if someone does not review them soon. Like I said we are shipping this in the RPM's right now. |
If you are confident and he is confident than I am confident. Merging. |
All of the MySQL related patches from the atomic spec
This a group of changes related to mysql that have been used in atomic rpm for some time.
@atomicturtle If you have sometime could you detail what this all is for the release notes.