Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_regex review #195

Merged
merged 27 commits into from
Apr 29, 2014
Merged

os_regex review #195

merged 27 commits into from
Apr 29, 2014

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Apr 29, 2014

changes:

  • replace octal values of charmaps with decimal ones (cause octal values greater than 127 causing conversion warnings)
  • change string size variables to size_t
  • rewrite OS_StrStartsWith() so that the length of the pattern does not need to be computed
  • enable unit test for regex extraction added by 79460ac
  • fix bunch of compiler warnings
  • fix coverity warnings about uninitialized array (CID 28590)

@cgzones
[os_regex] convert octal chars to decimal ones in regex maps, because…
ecc9ca1 
… octal values grater than \177 = 128 causing conversion warnings
@cgzones
[os_regex] fix compiler warnings
2529f5f
@cgzones
[os_regex] remove macro definitions already defined in os_regex.h
0c920d4
@cgzones
[os_regex] update makefile
aa1f181
@cgzones
[os_regex] fix compiler warnings about const discarding
e4de87f
@cgzones
[os_regex] lower scope of variables, suggested by cppcheck
7879795
@cgzones
[os_regex] size_t is always greater equal 0
d2c83d7
@cgzones
[os_regex] init matching function pointer of OSMatch with NULL
136811d
@cgzones
[os_regex] make pattern const in matching functions
5639c1e
@cgzones
[os_regex] free OSMatch elements independent from each other
4868068
@cgzones
[os_regex] remove solved todo
c2e8f88
@cgzones
[os_regex] simplification
eb8cb36
@cgzones
[os_regex] check for memory error before doing something else
29b8faa
@cgzones
[os_regex] make local functions static
917bbad
@cgzones
[os_regex] make pattern const in _OS_Regex
187eee0
@cgzones
[os_regex] OSRegex: free flags independent from patterns
f33275e
@cgzones
[os_regex] OS_WordMatch,OS_StrIsNum,OS_StrHowClosedMatch,OS_StrBreak:…
5d75fd7 
… make arguments const

OS_StrHowClosedMatch: change result tpye to size_t
@cgzones
[os_regex] rewrite OS_StrStartsWith, so that the length of the patter…
a5dc174 
…n does not need to be computed
@cgzones
[os_regex] declare OSRegex.prts_closure as const
6393515
@cgzones
[os_regex] fix segfault
44652b1
@cgzones
[os_regex] fix regex extraction introduced by 699ed9237554eea74c35f01…
cee19a8 
…325a61baf15312d86
@cgzones
[os_regex] fix regex extractions (add null termination)
ab9cfdf
@cgzones
[tests] enable regex extractions and fix warnings
e04198a
@cgzones
[os_regex] explicit declare parameters, which are not checked against…
7e949e6 
… null, as nonnull
@cgzones
[tests] fix missing const's
4cbdb93
@cgzones
[os_regex] initialize array
8914502
@cgzones
[os_regex] remove unused code
1970c27
jrossi added a commit that referenced this pull request Apr 29, 2014
@jrossi
Merge pull request #195 from cgzones/os_regex
73e1eb4 
os_regex review
@jrossi jrossi merged commit 73e1eb4 into ossec:master Apr 29, 2014
@cgzones cgzones deleted the os_regex branch May 2, 2014 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgzones @jrossi