Unittest os regex #139

jrossi · 2014-03-12T15:55:25Z

Basic import of os_regex/example/tests into check unit test setup start by @cgzones. This will test OS_Match2 and OS_Regex

jrossi · 2014-03-12T16:38:42Z

This is weird i am get different on my laptop:

./test_os_zlib
Running suite(s): os_zlib
100%: Checks: 9, Failures: 0, Errors: 0
./test_os_regex
Running suite(s): os_regex
100%: Checks: 4, Failures: 0, Errors: 0

cgzones · 2014-03-13T18:29:28Z

hi, you forgot to null-terminate the test arrays (thanks to valgrind and -g -O0)

cgzones · 2014-03-13T18:29:39Z

src/tests/test_os_regex.c

+        {"^\\S+ [(\\d+:\\d+:\\d+)] \\.+ (\\d+.\\d+.\\d+.\\d+)\\p*\\d* -> (\\d+.\\d+.\\d+.\\d+)\\p*", "snort: [1:590:12] RPC portmap ypserv request UDP [Classification: Decode of an RPC Query] [Priority: 2]: {UDP} 10.4.11.94:669 -> 10.4.3.20:111", ""},
+        {"^\\S+ [(\\d+:\\d+:\\d+)] \\.+ (\\d+.\\d+.\\d+.\\d+)\\p*\\d* -> (\\d+.\\d+.\\d+.\\d+)\\p*", "snort: [1:590:12] RPC portmap ypserv request UDP [Classification: Decode of an RPC Query] [Priority: 2]: {UDP} 10.4.11.94:670 -> 10.4.3.20:111", ""},
+        {"^\\S+ [(\\d+:\\d+:\\d+)] \\.+ (\\d+.\\d+.\\d+.\\d+)\\p*\\d* -> (\\d+.\\d+.\\d+.\\d+)\\p*", "snort: [1:1421:11] SNMP AgentX/tcp request [Classification: Attempted Information Leak] [Priority: 2]: {TCP} 10.4.12.26:37020 -> 10.4.10.231:705", ""}
+    };


jrossi · 2014-03-13T20:01:44Z

Thank you much - Should have seen that ;) thanks again

jrossi · 2014-03-13T20:41:02Z

@ossec tests work now. Thanks again @cgzones

Unittest os regex

jrossi added 4 commits March 12, 2014 03:15

adding os_regex Match2 unit test

7338747

added more unittests from os_regex/example

712bdca

cleaning up the code and formatting with astyle

8771b6d

make test will make all libs so they can start to be tested.

3126005

jrossi added the enhancement label Mar 12, 2014

jrossi added this to the ossec-hids-2.8 milestone Mar 12, 2014

cgzones reviewed Mar 13, 2014
View reviewed changes

add NULL terminated arrays as pointed out by @cgzones

3b24b04

ddpbsd added a commit that referenced this pull request Mar 13, 2014

Merge pull request #139 from jrossi/unittest-os_regex

27a2504

Unittest os regex

ddpbsd merged commit 27a2504 into ossec:master Mar 13, 2014

jrossi deleted the unittest-os_regex branch October 20, 2014 01:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unittest os regex #139

Unittest os regex #139

jrossi commented Mar 12, 2014

jrossi commented Mar 12, 2014

cgzones commented Mar 13, 2014

cgzones Mar 13, 2014

jrossi commented Mar 13, 2014

jrossi commented Mar 13, 2014

Unittest os regex #139

Unittest os regex #139

Conversation

jrossi commented Mar 12, 2014

jrossi commented Mar 12, 2014

cgzones commented Mar 13, 2014

cgzones Mar 13, 2014

Choose a reason for hiding this comment

jrossi commented Mar 13, 2014

jrossi commented Mar 13, 2014