-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EXPLAIN options (COSTS false) for some tests #148
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds the EXPLAIN OPTION '(COSTS false)' for test stability, because some tests don't need to check the costs.
BTW, the costs changed because the number of
|
Okay, thanks for this one. Applied down to 11, even if the difference only showed up on HEAD. |
michaelpq
added a commit
that referenced
this pull request
Aug 29, 2023
The commit adds the EXPLAIN OPTION '(COSTS false)' to improve the test stability, as these can get influences by upstream if the costing model changes for a reason or another like the recent upstrean change 82a4edabd272. This change does not influence the coverage of the test as the plans are the same, just the output produced. Per pull request #148. Author: Masahiro Ikeda Backpatch-through: 11
michaelpq
added a commit
that referenced
this pull request
Aug 29, 2023
The commit adds the EXPLAIN OPTION '(COSTS false)' to improve the test stability, as these can get influences by upstream if the costing model changes for a reason or another like the recent upstrean change 82a4edabd272. This change does not influence the coverage of the test as the plans are the same, just the output produced. Per pull request #148. Author: Masahiro Ikeda Backpatch-through: 11
michaelpq
added a commit
that referenced
this pull request
Aug 29, 2023
The commit adds the EXPLAIN OPTION '(COSTS false)' to improve the test stability, as these can get influences by upstream if the costing model changes for a reason or another like the recent upstrean change 82a4edabd272. This change does not influence the coverage of the test as the plans are the same, just the output produced. Per pull request #148. Author: Masahiro Ikeda Backpatch-through: 11
michaelpq
added a commit
that referenced
this pull request
Aug 29, 2023
The commit adds the EXPLAIN OPTION '(COSTS false)' to improve the test stability, as these can get influences by upstream if the costing model changes for a reason or another like the recent upstrean change 82a4edabd272. This change does not influence the coverage of the test as the plans are the same, just the output produced. Per pull request #148. Author: Masahiro Ikeda Backpatch-through: 11
michaelpq
added a commit
that referenced
this pull request
Aug 29, 2023
The commit adds the EXPLAIN OPTION '(COSTS false)' to improve the test stability, as these can get influences by upstream if the costing model changes for a reason or another like the recent upstrean change 82a4edabd272. This change does not influence the coverage of the test as the plans are the same, just the output produced. Per pull request #148. Author: Masahiro Ikeda Backpatch-through: 11
michaelpq
added a commit
that referenced
this pull request
Aug 29, 2023
The commit adds the EXPLAIN OPTION '(COSTS false)' to improve the test stability, as these can get influences by upstream if the costing model changes for a reason or another like the recent upstrean change 82a4edabd272. This change does not influence the coverage of the test as the plans are the same, just the output produced. Per pull request #148. Author: Masahiro Ikeda Backpatch-through: 11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds the EXPLAIN OPTION '(COSTS false)' for test stability, because some tests don't need to check the costs.
make installcheck
is failed after postgres/postgres@d37ab37 is committed because the costs is changed.(Might this only happen in my environment?)
Although only ut-A is failed on my laptop, I also fix ut-T because I have found that it can cause the same problem with the following query.