Migrate VCS plugins to new plugin API #9746
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
plugins/version-control-systems/git/src/main/kotlin/GitRepo.kt
Dismissed
Show dismissed
Hide dismissed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9746 +/- ##
=========================================
Coverage 68.08% 68.08%
Complexity 1293 1293
=========================================
Files 249 249
Lines 8845 8845
Branches 923 923
=========================================
Hits 6022 6022
Misses 2434 2434
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -202,7 +197,7 @@ abstract class VersionControlSystem { | |||
| fun isApplicableUrl(vcsUrl: String): Boolean { | |||
| if (vcsUrl.isBlank() || vcsUrl.endsWith(".html")) return false | |||
|
|
|||
| return isApplicableType(VcsHost.parseUrl(vcsUrl).type) || isApplicableUrlInternal(vcsUrl) | |||
| return type == VcsHost.parseUrl(vcsUrl).type || isApplicableUrlInternal(vcsUrl) | |||
There was a problem hiding this comment.
The removal of the public isApplicableType function should make this a breaking change.
There was a problem hiding this comment.
Yeah, I was a bit torn between keeping isApplicableType() (and using it more consistently), or removing it as it's so trivial. Any preference?
There was a problem hiding this comment.
Not really, we don't use it in the server code either, so I guess it's fine to remove it.
This is a fixup for debbc8d. Signed-off-by: Sebastian Schuberth <[email protected]>
The `isAvailable()` function just calls `isInPath()` on the `CommandLineTool`, which is the function being mocked. So these assertions test close to nothing. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
vcs-ksp-plugins
branch
from
6af795d to
2ee9448
Compare
This allows to simplify some code. Signed-off-by: Sebastian Schuberth <[email protected]>
Relates to #9403. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
vcs-ksp-plugins
branch
from
2ee9448 to
8df4ded
Compare
Please have a look at the individual commit messages for the details.