Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): Rename the typealias to get package details #9738

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

sschuberth
Copy link
Member

Make more clear that this is about getting package details, and use only "Fun" to resemble the corresponding Kotlin keyword.

@sschuberth sschuberth requested a review from a team as a code owner January 14, 2025 08:36
@sschuberth sschuberth enabled auto-merge (rebase) January 14, 2025 08:36
fviernau
fviernau previously approved these changes Jan 14, 2025
Make more clear that this is about *getting* package details, and use
only "Fun" to resemble the corresponding Kotlin keyword.

Signed-off-by: Sebastian Schuberth <[email protected]>
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (226d277) to head (b6ba461).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9738   +/-   ##
=========================================
  Coverage     68.08%   68.08%           
  Complexity     1293     1293           
=========================================
  Files           249      249           
  Lines          8845     8845           
  Branches        923      923           
=========================================
  Hits           6022     6022           
  Misses         2434     2434           
  Partials        389      389           
Flag Coverage Δ
funTest-docker 65.02% <100.00%> (ø)
funTest-non-docker 33.30% <ø> (ø)
test-ubuntu-24.04 35.91% <50.00%> (ø)
test-windows-2022 35.89% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth merged commit 95a192f into main Jan 14, 2025
25 of 26 checks passed
@sschuberth sschuberth deleted the GetPackageDetailsFun branch January 14, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants