-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: set correct version for runtime #7581
Conversation
f384730
to
832bcb1
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7581 +/- ##
=========================================
Coverage 68.03% 68.03%
Complexity 2022 2022
=========================================
Files 344 344
Lines 16723 16723
Branches 2370 2370
=========================================
Hits 11377 11377
Misses 4363 4363
Partials 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3fc06d0
to
6d5d0aa
Compare
@heliocastro I was looking once more at the scripts in ./github/workflows and for consistency with the other scripts what do you think of renaming "docker-ort-runtime.yml" to something like build-and-deploy-ort-container-image-runtime? And change the name from "name: Mega Docker runtime image" to "name: Build and Deploy ORT Runtime Container Image? |
On this PR i already moved the Mega name away. Renaming the workflows was really too much i think, and the only sensible change as @fviernau mentioned is the name of the PR itself. |
ea6fdae
to
a8c928a
Compare
Signed-off-by: Helio Chissini de Castro <[email protected]>
Main version is caught in the same manner as the docker_build script, with gradlew. Tag event will create the version with defined tag. Signed-off-by: Helio Chissini de Castro <[email protected]>
Signed-off-by: Helio Chissini de Castro <[email protected]>
a8c928a
to
ae1bdb3
Compare
Signed-off-by: Helio Chissini de Castro <[email protected]>
Main version is caught in the same manner as the
docker_build script, with gradlew.
Tag event will create the version with defined tag.