Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: set correct version for runtime #7581

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

heliocastro
Copy link
Contributor

Main version is caught in the same manner as the
docker_build script, with gradlew.
Tag event will create the version with defined tag.

@heliocastro heliocastro requested a review from a team as a code owner September 26, 2023 20:20
@heliocastro heliocastro self-assigned this Sep 26, 2023
@heliocastro heliocastro force-pushed the heliocastro/docker_runtime_version branch 2 times, most recently from f384730 to 832bcb1 Compare September 26, 2023 20:30
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (49bf674) 68.03% compared to head (2564299) 68.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7581   +/-   ##
=========================================
  Coverage     68.03%   68.03%           
  Complexity     2022     2022           
=========================================
  Files           344      344           
  Lines         16723    16723           
  Branches       2370     2370           
=========================================
  Hits          11377    11377           
  Misses         4363     4363           
  Partials        983      983           
Flag Coverage Δ
funTest-docker 69.40% <ø> (ø)
funTest-non-docker 36.44% <ø> (ø)
test 35.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heliocastro heliocastro force-pushed the heliocastro/docker_runtime_version branch from 3fc06d0 to 6d5d0aa Compare September 26, 2023 20:51
@heliocastro heliocastro changed the title Set correct version for runtime docker: set correct version for runtime Sep 26, 2023
@tsteenbe
Copy link
Member

@heliocastro I was looking once more at the scripts in ./github/workflows and for consistency with the other scripts what do you think of renaming "docker-ort-runtime.yml" to something like build-and-deploy-ort-container-image-runtime? And change the name from "name: Mega Docker runtime image" to "name: Build and Deploy ORT Runtime Container Image?

@heliocastro
Copy link
Contributor Author

@heliocastro I was looking once more at the scripts in ./github/workflows and for consistency with the other scripts what do you think of renaming "docker-ort-runtime.yml" to something like build-and-deploy-ort-container-image-runtime? And change the name from "name: Mega Docker runtime image" to "name: Build and Deploy ORT Runtime Container Image?

On this PR i already moved the Mega name away. Renaming the workflows was really too much i think, and the only sensible change as @fviernau mentioned is the name of the PR itself.
So my vote is keep the way it is only with the name change.

@heliocastro heliocastro force-pushed the heliocastro/docker_runtime_version branch 4 times, most recently from ea6fdae to a8c928a Compare September 27, 2023 19:53
Signed-off-by: Helio Chissini de Castro <[email protected]>
Main version is caught in the same manner as the
docker_build script, with gradlew.
Tag event will create the version with defined tag.

Signed-off-by: Helio Chissini de Castro <[email protected]>
Signed-off-by: Helio Chissini de Castro <[email protected]>
@heliocastro heliocastro force-pushed the heliocastro/docker_runtime_version branch from a8c928a to ae1bdb3 Compare September 28, 2023 07:03
@tsteenbe tsteenbe merged commit f705d56 into main Sep 29, 2023
36 checks passed
@tsteenbe tsteenbe deleted the heliocastro/docker_runtime_version branch September 29, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants