Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(GoModFunTest): Cover the case of a non-empty VCS path #6527

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Feb 21, 2023

Add github.com/hashicorp/go-secure-stdlib/parseutil as direct dependency, to have at least one dependency for which the go.mod file does not reside in the root directory of its repository.

Note: This prepares for changing the implementation of GoMod within the context of #5555.

@fviernau fviernau requested a review from a team as a code owner February 21, 2023 12:02
Add `github.com/hashicorp/go-secure-stdlib/parseutil` as direct
dependency, to have at least one dependency for which the `go.mod` file
does not reside in the root directory of its repository.

Signed-off-by: Frank Viernau <[email protected]>
@fviernau fviernau force-pushed the go-mod-fun-test-extend-test-asset branch from a71d23d to 5203ddb Compare February 21, 2023 12:56
@fviernau fviernau merged commit 60501c0 into main Feb 21, 2023
@fviernau fviernau deleted the go-mod-fun-test-extend-test-asset branch February 21, 2023 13:53
@fviernau
Copy link
Member Author

Merged despite failing unrelated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants