Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: Enable Docker layer caching between builds #5070

Closed
wants to merge 5 commits into from

Conversation

sschuberth
Copy link
Member

For details see 1.

Signed-off-by: Sebastian Schuberth [email protected]

@sschuberth sschuberth force-pushed the docker-github-caching branch from 0b834bd to 7cebbef Compare August 28, 2022 08:31
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (62e90ad) 64.34% compared to head (4feb8c7) 64.34%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5070   +/-   ##
=========================================
  Coverage     64.34%   64.34%           
  Complexity     1960     1960           
=========================================
  Files           327      327           
  Lines         16529    16529           
  Branches       2359     2359           
=========================================
  Hits          10635    10635           
  Misses         4875     4875           
  Partials       1019     1019           
Flag Coverage Δ
funTest-non-docker 30.16% <ø> (ø)
test 39.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sschuberth sschuberth force-pushed the docker-github-caching branch from bd45950 to fb401d7 Compare August 29, 2022 06:18
@sschuberth
Copy link
Member Author

This is currently blocked by batect/docker-client#244.

@sschuberth sschuberth added the on hold Pull requests that cannot currently be merged label Sep 7, 2022
@sschuberth sschuberth force-pushed the docker-github-caching branch 8 times, most recently from 9745cf7 to 8298ed1 Compare April 28, 2023 17:09
@sschuberth sschuberth force-pushed the docker-github-caching branch 3 times, most recently from a858ae0 to 977ceae Compare May 4, 2023 14:48
sschuberth added 5 commits May 4, 2023 17:57
Also do not wrap the comments too early, they now actually fit into a
single line each.

Signed-off-by: Sebastian Schuberth <[email protected]>
…nore

This avoids the Docker image to be rebuilt because of Batect cache
changes.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth force-pushed the docker-github-caching branch from 977ceae to 4feb8c7 Compare May 4, 2023 16:22
@sschuberth
Copy link
Member Author

The contained .dockerignore improvements have been moved out to #7542. The caching improvements are superseded by the approach outlined at #7474.

@sschuberth sschuberth closed this Sep 20, 2023
@sschuberth sschuberth deleted the docker-github-caching branch September 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Pull requests that cannot currently be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant