-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create github action to build and upload Docker image #5015
Conversation
This github action builds a Docker image from the ort source, and uploads it to the github Docker container registry. This allows users to run ort by simply installing from the container registry with a one liner like: $ docker pull ghcr.io/oss-review-toolkit/ort:master and then running it via $ docker run ort Signed-off-by: Andreas Bogk <[email protected]>
Thanks for your contribution @andreasdotorg. The ORT steering team @oss-review-toolkit/core-devs would need to decide what is required (from a non-technical point of view) to publish such an image. |
I understand and appreciate the concerns. I might be back with a solution or not. |
with: | ||
submodules: recursive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shouldn't be necessary as we use Git submodules exclusively for referring to external functional test projects.
submodules: recursive | ||
|
||
- name: Log in to the Container registry | ||
if: github.event_name != 'pull_request' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary as the on:
above does not contain pull_request:
?
BTW, nice to meet you again, @andreasdotorg 😃 |
Great to see a familiar face @andreasdotorg, are you using ORT just personally or at work? |
This has been superseded by #7474. |
This github action builds a Docker image from the ort source, and uploads it to the github Docker container registry. This allows users to run ort by simply installing from the container registry with a one liner like:
$ docker pull ghcr.io/oss-review-toolkit/ort:master
and then running it via
$ docker run ort
Signed-off-by: Andreas Bogk [email protected]