Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github action to build and upload Docker image #5015

Closed

Conversation

andreasdotorg
Copy link

This github action builds a Docker image from the ort source, and uploads it to the github Docker container registry. This allows users to run ort by simply installing from the container registry with a one liner like:

$ docker pull ghcr.io/oss-review-toolkit/ort:master

and then running it via

$ docker run ort

Signed-off-by: Andreas Bogk [email protected]

This github action builds a Docker image from the ort source, and uploads it to the github Docker container registry. This allows users to run ort by simply installing from the container registry with a one liner like:

$ docker pull ghcr.io/oss-review-toolkit/ort:master

and then running it via

$ docker run ort

Signed-off-by: Andreas Bogk <[email protected]>
@andreasdotorg andreasdotorg requested a review from a team as a code owner February 1, 2022 21:03
@MarcelBochtler
Copy link
Member

Thanks for your contribution @andreasdotorg.
Please be aware of the discussion about releasing a public ORT image.
Specifically, this comment from @tsteenbe.

The ORT steering team @oss-review-toolkit/core-devs would need to decide what is required (from a non-technical point of view) to publish such an image.

@andreasdotorg
Copy link
Author

I understand and appreciate the concerns. I might be back with a solution or not.

Comment on lines +21 to +22
with:
submodules: recursive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be necessary as we use Git submodules exclusively for referring to external functional test projects.

submodules: recursive

- name: Log in to the Container registry
if: github.event_name != 'pull_request'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary as the on: above does not contain pull_request:?

@sschuberth
Copy link
Member

BTW, nice to meet you again, @andreasdotorg 😃

@tsteenbe
Copy link
Member

tsteenbe commented Feb 5, 2022

Great to see a familiar face @andreasdotorg, are you using ORT just personally or at work?

@sschuberth
Copy link
Member

This has been superseded by #7474.

@sschuberth sschuberth closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants