Add FSM loop timings #2868
Merged
Add FSM loop timings #2868
+177
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the issue osrg#2854 demonstrates, Main FSM loop performance is crucial for overall GoBGP performance. While we're far from hitting those limits yet, we want to be sure that we have enough capacity in FSM loop. To achieve that, we add FSM loop timing histograms, which are showing: - timing_sec - amount of time handling each message took - wait_sec - amount of time each message spent in a channel before it was received by the main FSM loop. The latter (wait times) allows to detect situation when FSM loop performance is inadequate, while the former (timings) allows to understand which component causes such delays. For the sake of simplicity, further classification of message types, such as RouterID of the peer or name of gRPC operation is not made.
|
Looks interesting. Pushed, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the issue #2854 demonstrates, Main FSM loop performance is crucial for overall GoBGP performance. While we're far from hitting those limits yet, we want to be sure that we have enough capacity in FSM loop.
To achieve that, we add FSM loop timing histograms, which are showing:
- timing_sec - amount of time handling each message took
- wait_sec - amount of time each message spent in a channel before it was received by the main FSM loop. The latter (wait times) allows to detect situation when FSM loop performance is inadequate, while the former (timings) allows to understand which component causes such delays.
For the sake of simplicity, further classification of message types, such as RouterID of the peer or name of gRPC operation is not made.