Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added added-mass values to .sdf files #115

Merged
merged 75 commits into from
Feb 7, 2023
Merged

Conversation

hamilton8415
Copy link
Collaborator

Added added-mass values for all links in .sdf file. Values are intended to match documentation at: https://osrf.github.io/buoy_entrypoint/pr-preview/pr-17/theory/

chapulina and others added 30 commits August 17, 2022 14:52
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Dharini Dutia <[email protected]>
- Update library and namespaces for ign -> gz migration.
- Use `python -m em` rather than `empy` for macOS support.
- Update dependencies to ros_gz_bridge and ros_gz_sim

Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Dharini Dutia <[email protected]>
Signed-off-by: Dharini Dutia <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mabelzhang mabelzhang linked an issue Jan 23, 2023 that may be closed by this pull request
5 tasks
@mabelzhang
Copy link
Collaborator

@robertmcewen to review

@mabelzhang mabelzhang mentioned this pull request Jan 23, 2023
5 tasks
andermi added a commit that referenced this pull request Jan 25, 2023
@quarkytale
Copy link
Contributor

quarkytale commented Jan 26, 2023

Tests are failing with this one, need to update valve absement, working on it

Signed-off-by: Dharini Dutia <[email protected]>
Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values match the doc, lgtm after tests pass

Update: Only PC tests are failing regarding winding current

andermi added a commit that referenced this pull request Jan 31, 2023
* proof of concept for looping over simulation parameters

Signed-off-by: Michael Anderson <[email protected]>

* try to fix

Signed-off-by: Michael Anderson <[email protected]>

* set on_exit shutdown in launch files

Signed-off-by: Michael Anderson <[email protected]>

* install script and example batch sim params; add launch file; set default to use example sim params

Signed-off-by: Michael Anderson <[email protected]>

* add rosbag and a log file; rename some things

Signed-off-by: Michael Anderson <[email protected]>

* fix max scale in example yaml

Signed-off-by: Michael Anderson <[email protected]>

* typo

Signed-off-by: Michael Anderson <[email protected]>

* remove noisy prints; get tests passing

Signed-off-by: Michael Anderson <[email protected]>

* use argparse

Signed-off-by: Michael Anderson <[email protected]>

* mbari_wec/model.sdf is now generated by empy

Signed-off-by: Michael Anderson <[email protected]>

* try to debug pc commands test

Signed-off-by: Michael Anderson <[email protected]>

* debug pc commands test

Signed-off-by: Michael Anderson <[email protected]>

* increase timeout; remove debugging prints

Signed-off-by: Michael Anderson <[email protected]>

* keep debugging

Signed-off-by: Michael Anderson <[email protected]>

* keep debugging

Signed-off-by: Michael Anderson <[email protected]>

* keep debugging

Signed-off-by: Michael Anderson <[email protected]>

* remove debugging code

Signed-off-by: Michael Anderson <[email protected]>

* set z_ww for doors open/closed -- unused until #115

Signed-off-by: Michael Anderson <[email protected]>

* fix argparse

Signed-off-by: Michael Anderson <[email protected]>

* cleanup prints; remove default arg for batch launch

Signed-off-by: Michael Anderson <[email protected]>

* change iterations to duration in batch params yaml

Signed-off-by: Michael Anderson <[email protected]>

* clean up

Signed-off-by: Michael Anderson <[email protected]>

* clean up

Signed-off-by: Michael Anderson <[email protected]>

* added plumbing for random seed but not yet supported by our version of gz sim

Signed-off-by: Michael Anderson <[email protected]>

* make new directory for batch results; copy params yaml to results; timestamp everything; put rosbag names in log

Signed-off-by: Michael Anderson <[email protected]>

* add some info prints

Signed-off-by: Michael Anderson <[email protected]>

* flake8

Signed-off-by: Michael Anderson <[email protected]>

* error checking; let --seed be optional and other params default; duration required

Signed-off-by: Michael Anderson <[email protected]>

* connect batching template to viscous drag plugin

Signed-off-by: Michael Anderson <[email protected]>

* retest until pass

Signed-off-by: Michael Anderson <[email protected]>

---------

Signed-off-by: Michael Anderson <[email protected]>
@andermi
Copy link
Collaborator

andermi commented Feb 4, 2023

I'll debug the expected winding current difference, and then I think this will be ready to merge

@andermi andermi enabled auto-merge (squash) February 7, 2023 19:25
@andermi andermi merged commit c8c0d4f into main Feb 7, 2023
@andermi andermi deleted the added-mass-values-in-sdf branch February 7, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added mass
7 participants