Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logging to previously silent mesh finding failure. #188

Open
wants to merge 1 commit into
base: gzweb_1.4.0
Choose a base branch
from
Open

Adding logging to previously silent mesh finding failure. #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions gz3d/src/gziface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,6 +960,13 @@ GZ3D.GZIface.prototype.createGeom = function(geom, material, parent)
if (idx > 1)
{
modelName = meshUri.substring(meshUri.lastIndexOf('/', idx-1));
} else {
console.log('Could not establish a local filename for mesh: "' +
meshUri +
'". Mesh URIs using an absolute path syntax should use ' +
'the ROS-standard directory structure of ' +
'"<package_path>/meshes/<mesh_path>", e.g. ' +
'"/home/user/workspace/src/ur_description/meshes/base.dae".');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GzWeb is not ROS-specific, do you mind rephrasing the warning so it doesn't mention ROS? I know that the comment above mentions gazebo_ros_pkgs as an example of how a user may end up here, but there are other ways in which absolute paths could be passed to Gazebo too.

How about something like:

"Mesh URIs using an absolute path syntax should be located inside a meshes directory, e.g. /home/user/workspace/src/ur_description/meshes/base.dae"

}
}
if (modelName.length > 0)
Expand Down