Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version in gzweb_install tutorial #146

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

jazibdawre
Copy link
Contributor

Hey, the node version specified in the gzweb_install tutorial didn't work osrf/gzweb#217 osrf/gzweb#173 . I tested it on Ubuntu 18.04 amd64 with gazebo 9 and have updated the version.

v6.17.1 (npm v3.10.10): Build Error
v7.10.1 (npm v4.2.0): Build Error

gzweb/node_modules/micromatch/index.js:44
    let isMatch = picomatch(String(patterns[i]), { ...options, onResult }, true);
                                                   ^^^

SyntaxError: Unexpected token ...

v8.17.0 (npm v6.13.4): Build OK, Run OK
v9.11.2 (npm v5.6.0): Build OK, Run OK
v10.24.1 (npm v6.14.12): Build OK, Run OK [Deprecation Warnings]
v11.15.0 (npm v6.7.0): Build OK, Run OK [Deprecation Warnings]

v12.22.1 (npm v6.14.12): Build Error

In file included from ../GZNode.cc:19:0:
../GZNode.hh:36:30: error: ‘v8::Handle’ has not been declared
     public: static void Init(v8::Handle<v8::Object> exports);

The version 1.4.1 in the tutorial needs to have osrf/gzweb#205 applied so I kept it out of the list.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for the updating the tutorial instructions

@iche033 iche033 merged commit 564f444 into osrf:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants