don't pass rosdistro when using empty index#85
Merged
mikaelarguedas merged 1 commit intoosrf:masterfrom Apr 7, 2020
Merged
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of osrf/docker_images#307 the
ros2:nightly*images use an empty rosdistro index to prevent users from installing released ROS packages via rosdep.As a consequence, specifying which rosdistro to update brings no benefit as there aren't any distro in the index. Since rosdep 0.19.0,
rosdep updatefails if therosdistropassed to it is unknown.To fix the build of the nightly images this removes the
--rosdistrofromrosdep updatein all the nightly images