Skip to content

Create Noetic dockerfiles#405

Merged
ruffsl merged 6 commits intomasterfrom
noetic
May 26, 2020
Merged

Create Noetic dockerfiles#405
ruffsl merged 6 commits intomasterfrom
noetic

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Contributor

These files won't compile just yet, because apparently the ROS bootstrap tools are not released in their python2 version for focal.

We'll need to modify the bootstrap tools template to not only use the ros_version but to also get the ROS_PYTHON_VERSION to install the tools accordingly. It would be great to get it from e.g. rosdistro rather than hard-coding it.

@sloretz FYI

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas mentioned this pull request May 25, 2020
@ruffsl
Copy link
Copy Markdown
Member

ruffsl commented May 25, 2020

Is that something we could put in the platform yaml? ros_python_version

ruffsl
ruffsl previously requested changes May 25, 2020
# install bootstrap tools
RUN apt-get update && apt-get install --no-install-recommends -y \
build-essential \
python-rosdep \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thought you meant the template wouldn't compile the same Dockerfiles, as if you had patched them manually.

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
Copy link
Copy Markdown
Contributor Author

As discussed offline with @ruffsl , right now we monkey-patch the dockerfile by hand to enable the initial release.

The better approach will be to use rosdistro to get the missing information. Follow-up tracking ticket at #406

@mikaelarguedas mikaelarguedas marked this pull request as ready for review May 26, 2020 21:32
@mikaelarguedas
Copy link
Copy Markdown
Contributor Author

Images built and smoke-tested locally with:

source /opt/ros/noetic/setup.bash 
rosrun rospy_tutorials add_two_ints_server &
rosrun roscpp_tutorials add_two_ints_client 3 5

@ruffsl ruffsl merged commit 850fcf8 into master May 26, 2020
@ruffsl ruffsl deleted the noetic branch May 26, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants