Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Merged
ruffsl
approved these changes
May 25, 2020
Member
|
Is that something we could put in the platform yaml? |
ruffsl
previously requested changes
May 25, 2020
| # install bootstrap tools | ||
| RUN apt-get update && apt-get install --no-install-recommends -y \ | ||
| build-essential \ | ||
| python-rosdep \ |
Member
There was a problem hiding this comment.
Ah, thought you meant the template wouldn't compile the same Dockerfiles, as if you had patched them manually.
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Contributor
Author
Contributor
Author
|
Images built and smoke-tested locally with: |
ruffsl
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files won't compile just yet, because apparently the ROS bootstrap tools are not released in their python2 version for focal.
We'll need to modify the bootstrap tools template to not only use the
ros_versionbut to also get theROS_PYTHON_VERSIONto install the tools accordingly. It would be great to get it from e.g. rosdistro rather than hard-coding it.@sloretz FYI