revert no-install-recommends on ros2 daily images#398
Conversation
ruffsl
left a comment
ruffsl
left a comment
There was a problem hiding this comment.
I was thinking no-install-recommends changes would root out some more upstream issues. Nice catch. No action needed for the other library tags?
I haven't uncovered other issues yet. for the ros and gazebo ones it is not saying much as I just merged the change but haven't PR'd it to the official docker images yet...So noone but people building images themselves have been using them yet. Hoping to leverage things learned on the ros2 images to have better assessment of potential impact on ros and gazebo images. So far the rosdep issue seems ROS 2 specific as almost no package in all ROS 1 (kinetic + melodic) are using the |
|
hmmm that build failure is not expected. |
Currently some overlays would fail to build because of ros-infrastructure/rosdep#752 Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
revert-no-install-recommends-ros2
branch
from
d23363a to
72c1b66
Compare
|
Rebased on top of #399 and CI is now green. |
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
2 participants
This reverts temporarily the part of #357 applying to the ros2 devel, source and nightly images.
Currently some overlays would fail to build because of
ros-infrastructure/rosdep#752
(Will fail CI because not matching the templates anymore)
Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com