Skip to content

Added noetic dockerfiles for ubuntu focal#394

Closed
ahcorde wants to merge 1 commit intomasterfrom
noetic
Closed

Added noetic dockerfiles for ubuntu focal#394
ahcorde wants to merge 1 commit intomasterfrom
noetic

Conversation

@ahcorde
Copy link
Copy Markdown

@ahcorde ahcorde commented Mar 25, 2020

we need to create the noetic dockerfiles to support some CI jobs (for example in the perception pipeline: ros-perception/image_pipeline#507).

Meta packages such as: ros-noetic-ros-core, ros-noetic-ros-base, etc are not created yet. Fow now it's not possible to build these dockerfiles.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from sloretz March 25, 2020 11:29
@ahcorde ahcorde self-assigned this Mar 25, 2020
Copy link
Copy Markdown

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Thank you very much for working on this. I am trying to get it these images to run locally to debug some early noetic buildfarm/release issues. Please find comments inline for local changes I made.

Is there a "working" Dockerfile for debugging jobs on the noetic buildfarm yet?

Thanks,
Wolfgang


# install ros packages
RUN apt-get update && apt-get install -y \
ros-focal-robot \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be ros-noetic-robot


# setup sources.list
RUN echo "deb http://repositories.ros.org/ubuntu/testing focal main" > /etc/apt/sources.list.d/ros1-latest.list
RUN echo "deb http://packages.ros.org/ros/ubuntu bionic main" > /etc/apt/sources.list.d/ros1-latest.list
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

focal main?

@mikaelarguedas
Copy link
Copy Markdown
Contributor

mikaelarguedas commented Apr 2, 2020

@wxmerkt

Is there a "working" Dockerfile for debugging jobs on the noetic buildfarm yet?

Recommended way to debug buildfarm jobs is to use the ros_buildfarm package.
Some information on how to run buildfarm jobs locally can be found at https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/index.rst#run-jobs-locally


@ahcorde the docker_images on this repositories are generated. However they won't be generated and pushed upstream before the release actually happens.
As this PR looks hand-crafted and not complying with the templates or expected tags, it is likely that it will be rejected in favor of a PR containing the generated Dockerfiles.
A branch containing the changes for Foxy + Noetic is pending at master...mikaelarguedas:noetic-foxy

@ahcorde
Copy link
Copy Markdown
Author

ahcorde commented Apr 2, 2020

Sure, closed

@ahcorde ahcorde closed this Apr 2, 2020
@mikaelarguedas
Copy link
Copy Markdown
Contributor

@ahcorde Are you using this branch for something on your side? or can it be safely deleted ?

@wxmerkt
Copy link
Copy Markdown

wxmerkt commented Apr 2, 2020

@mikaelarguedas Thank you for the pointers, much appreciated :-)

@ahcorde ahcorde deleted the noetic branch April 2, 2020 11:05
@ahcorde
Copy link
Copy Markdown
Author

ahcorde commented Apr 2, 2020

Removed @mikaelarguedas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants