fix: mempool filter ibc spam #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
requested review from
nicolaslara,
p0mvn and
AlpinYukseloglu
as code owners
p0mvn
reviewed
Jun 18, 2024
Comment on lines
+65
to
+97
| msgs := tx.GetMsgs() | ||
| for _, msg := range msgs { | ||
| // If one of the msgs is an IBC Transfer msg, limit it's size due to current spam potential. | ||
| // 500KB for entire msg | ||
| // 400KB for memo | ||
| // 65KB for receiver | ||
| if transferMsg, ok := msg.(*transfertypes.MsgTransfer); ok { | ||
| if transferMsg.Size() > 500000 { // 500KB | ||
| return ctx, errorsmod.Wrap(sdkerrors.ErrInvalidRequest, "msg size is too large") | ||
| } | ||
|
|
||
| if len([]byte(transferMsg.Memo)) > 400000 { // 400KB | ||
| return ctx, errorsmod.Wrap(sdkerrors.ErrInvalidRequest, "memo is too large") | ||
| } | ||
|
|
||
| if len(transferMsg.Receiver) > 65000 { // 65KB | ||
| return ctx, errorsmod.Wrap(sdkerrors.ErrInvalidRequest, "receiver address is too large") | ||
| } | ||
| } | ||
|
|
||
| // If one of the msgs is from ICA, limit it's size due to current spam potential. | ||
| // 500KB for packet data | ||
| // 65KB for sender | ||
| if icaMsg, ok := msg.(*icacontrollertypes.MsgSendTx); ok { | ||
| if icaMsg.PacketData.Size() > 500000 { // 500KB | ||
| return ctx, errorsmod.Wrap(sdkerrors.ErrInvalidRequest, "packet data is too large") | ||
| } | ||
|
|
||
| if len([]byte(icaMsg.Owner)) > 65000 { // 65KB | ||
| return ctx, errorsmod.Wrap(sdkerrors.ErrInvalidRequest, "owner address is too large") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Consider copying some of the violating message JSONs from mintscan and adding them as unit tests
There is an example with arbitrage filters to help with boilerplate setup for this
There was a problem hiding this comment.
Tests added here 179d7e7
ValarDragon
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Limits IBC Transfer messages to the following:
Limit ICA Send message to the following:
I opted to hard code these since adding them to the config would be deprecated in the next release. LMK if you think I should add them as config params.